Subru Krishnan commented on YARN-2690:

Thanks [~adhoot] for the patch. This is a good improvement as it minimizes the 
scheduler specific implementation for the reservation system.

The patch overall looks good. Just a minor comment - can you move 
_initializePlan()_, _getReplanner()_, _getAgent()_ & _getAdmissionPolicy()_ 
from _CapacityReservationSystem_ to _AbstractReservationSystem_ as now they are 
scheduler implementation agnostic.

> Make ReservationSystem and its dependent classes independent of Scheduler 
> type  
> --------------------------------------------------------------------------------
>                 Key: YARN-2690
>                 URL: https://issues.apache.org/jira/browse/YARN-2690
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: fairscheduler
>            Reporter: Anubhav Dhoot
>            Assignee: Anubhav Dhoot
>         Attachments: YARN-2690.001.patch
> A lot of common reservation classes depend on CapacityScheduler and 
> specifically its configuration. This jira is to make them ready for other 
> Schedulers by abstracting out the configuration.

This message was sent by Atlassian JIRA

Reply via email to