Subru Krishnan commented on YARN-2690:

Thanks [~adhoot] for updating the patch. +1 from my side.

Couple of minor nits:
  * We could have a protected _ReservationSchedulerConfiguration_ variable in 
_AbstractReservationSystem_ to avoid invoking 
_ReservationSchedulerConfiguration reservationConfig = 
getReservationSchedulerConfiguration()_ everywhere.
  * It'll be good to have some Javadocs for _ReservationSchedulerConfiguration_ 
describing what the reservation system configs are.

> Make ReservationSystem and its dependent classes independent of Scheduler 
> type  
> --------------------------------------------------------------------------------
>                 Key: YARN-2690
>                 URL: https://issues.apache.org/jira/browse/YARN-2690
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: fairscheduler
>            Reporter: Anubhav Dhoot
>            Assignee: Anubhav Dhoot
>         Attachments: YARN-2690.001.patch, YARN-2690.002.patch, 
> YARN-2690.002.patch
> A lot of common reservation classes depend on CapacityScheduler and 
> specifically its configuration. This jira is to make them ready for other 
> Schedulers by abstracting out the configuration.

This message was sent by Atlassian JIRA

Reply via email to