[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14186047#comment-14186047 ]
zhihai xu commented on YARN-2753: --------------------------------- [~leftnoteasy], thanks to review the patch, I remove labels == null in the new patch YARN-2753.001.patch. > potential NPE in checkRemoveLabelsFromNode of CommonNodeLabelsManager > --------------------------------------------------------------------- > > Key: YARN-2753 > URL: https://issues.apache.org/jira/browse/YARN-2753 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: zhihai xu > Assignee: zhihai xu > Attachments: YARN-2753.000.patch, YARN-2753.001.patch > > > potential NPE(NullPointerException) in checkRemoveLabelsFromNode of > CommonNodeLabelsManager. > It because when a Node is created, Node.labels can be null. > In this case, nm.labels; may be null. > So we need check originalLabels not null before use > it(originalLabels.containsAll). -- This message was sent by Atlassian JIRA (v6.3.4#6332)