Jonathan Eagles commented on YARN-2375:

[~zjshen], you misunderstand my request. I am proposing to retain the flag. 
However, the responsibility of checking whether the ats is enabled needs to be 
outside of the TimelineClientImpl. In fact, the code in yarn assumes the design 
I am proposing. In YarnClient it checks the value of ats.enabled, then it 
creates the TimelineClientImpl which then re-checks ats.enabled. This is the 
preferred object design.

The issues lies in the fact the the timeline delegation token renewer creates a 
TimelineClient because it has a timeline server delegation token. This is proof 
enough that a timelineclient needs to be created. This goes back to my original 
design constraint that ats.enabled must be able to be turned off globally, and 
enabled at the per job/framework level.

> Allow enabling/disabling timeline server per framework
> ------------------------------------------------------
>                 Key: YARN-2375
>                 URL: https://issues.apache.org/jira/browse/YARN-2375
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jonathan Eagles
>            Assignee: Mit Desai
> This JIRA is to remove the ats enabled flag check within the 
> TimelineClientImpl. Example where this fails is below.
> While running secure timeline server with ats flag set to disabled on 
> resource manager, Timeline delegation token renewer throws an NPE. 

This message was sent by Atlassian JIRA

Reply via email to