[
https://issues.apache.org/jira/browse/YARN-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14218595#comment-14218595
]
Zhijie Shen commented on YARN-2375:
-----------------------------------
Looks good to me overall, except some minor issues:
1. can we add a test case in TestMRTimelineEventHandling to check the scenario
that MAPREDUCE_JOB_EMIT_TIMELINE_DATA = true, TIMELINE_SERVICE_ENABLED = false
and MiniMRYarnCluster doesn't start the timeline server?
2. In ApplicationMaster.finish(), let's stop the timeline client?
3. Fix the indent issue in TimelineClientImpl#serviceInit().
4. {{LOG.info("Timeline server is (not) enabled");}} -> {{LOG.info("Timeline
service is (not) enabled");}}? To be consistent with the log sentence in other
places.
> Allow enabling/disabling timeline server per framework
> ------------------------------------------------------
>
> Key: YARN-2375
> URL: https://issues.apache.org/jira/browse/YARN-2375
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jonathan Eagles
> Assignee: Mit Desai
> Attachments: YARN-2375.patch, YARN-2375.patch, YARN-2375.patch
>
>
> This JIRA is to remove the ats enabled flag check within the
> TimelineClientImpl. Example where this fails is below.
> While running secure timeline server with ats flag set to disabled on
> resource manager, Timeline delegation token renewer throws an NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
