[ 
https://issues.apache.org/jira/browse/YARN-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216407#comment-14216407
 ] 

Chen He commented on YARN-2165:
-------------------------------

Hi [~vasanthkumar], thank you for the patch. A small nit in the unit test code. 
Once the unit test gets expected exception, it will be great to verify which 
parameter produces this exception. 

eg. verify the message in exception to check which parameter causes this 
exception.

> Timelineserver should validate that yarn.timeline-service.ttl-ms is greater 
> than zero
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-2165
>                 URL: https://issues.apache.org/jira/browse/YARN-2165
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Karam Singh
>            Assignee: Vasanth kumar RJ
>         Attachments: YARN-2165.1.patch, YARN-2165.patch
>
>
> Timelineserver should validate that yarn.timeline-service.ttl-ms is greater 
> than zero
> Currently if set yarn.timeline-service.ttl-ms=0 
> Or yarn.timeline-service.ttl-ms=-86400 
> Timeline server start successfully with complaining
> {code}
> 2014-06-15 14:52:16,562 INFO  timeline.LeveldbTimelineStore 
> (LeveldbTimelineStore.java:<init>(247)) - Starting deletion thread with ttl 
> -604800000 and cycle interval 300000
> {code}
> At starting timelinserver should that yarn.timeline-service-ttl-ms > 0
> otherwise specially for -ive value discard oldvalues timestamp will be set 
> future value. Which may lead to inconsistancy in behavior 
> {code}
>     public void run() {
>       while (true) {
>         long timestamp = System.currentTimeMillis() - ttl;
>         try {
>           discardOldEntities(timestamp);
>           Thread.sleep(ttlInterval);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to