[ https://issues.apache.org/jira/browse/YARN-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216765#comment-14216765 ]
Hadoop QA commented on YARN-2165: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12682226/YARN-2165.2.patch against trunk revision bcd402a. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice: org.apache.hadoop.yarn.server.timeline.security.TestTimelineAuthenticationFilter {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5868//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5868//console This message is automatically generated. > Timelineserver should validate that yarn.timeline-service.ttl-ms is greater > than zero > ------------------------------------------------------------------------------------- > > Key: YARN-2165 > URL: https://issues.apache.org/jira/browse/YARN-2165 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Reporter: Karam Singh > Assignee: Vasanth kumar RJ > Attachments: YARN-2165.1.patch, YARN-2165.2.patch, YARN-2165.patch > > > Timelineserver should validate that yarn.timeline-service.ttl-ms is greater > than zero > Currently if set yarn.timeline-service.ttl-ms=0 > Or yarn.timeline-service.ttl-ms=-86400 > Timeline server start successfully with complaining > {code} > 2014-06-15 14:52:16,562 INFO timeline.LeveldbTimelineStore > (LeveldbTimelineStore.java:<init>(247)) - Starting deletion thread with ttl > -604800000 and cycle interval 300000 > {code} > At starting timelinserver should that yarn.timeline-service-ttl-ms > 0 > otherwise specially for -ive value discard oldvalues timestamp will be set > future value. Which may lead to inconsistancy in behavior > {code} > public void run() { > while (true) { > long timestamp = System.currentTimeMillis() - ttl; > try { > discardOldEntities(timestamp); > Thread.sleep(ttlInterval); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)