Jason Lowe commented on YARN-1984:

Thanks for picking this up, Varun.

getStartTimeLong can leak the runtime DBException and shouldn't.

Is there a reason to have deleteNextEntity throw DBException rather than 
IOException?  It would be cleaner for callers if deleteNextEnttiy handled this.

loadVersion can leak the runtime DBException

> LeveldbTimelineStore does not handle db exceptions properly
> -----------------------------------------------------------
>                 Key: YARN-1984
>                 URL: https://issues.apache.org/jira/browse/YARN-1984
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.4.0
>            Reporter: Jason Lowe
>            Assignee: Varun Saxena
>             Fix For: 2.7.0
>         Attachments: YARN-1984.patch
> The org.iq80.leveldb.DB and DBIterator methods throw runtime exceptions 
> rather than IOException which can easily leak up the stack and kill threads 
> (e.g.: the deletion thread).

This message was sent by Atlassian JIRA

Reply via email to