[
https://issues.apache.org/jira/browse/YARN-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223221#comment-14223221
]
Varun Saxena commented on YARN-1984:
------------------------------------
Thanks for the review [~jlowe].
I had missed handling DBException at one place and other places didnt handle
because the caller method was handling DBException.
But in hindsight, I think we should handle the DBException in all the methods
you mentioned above, as the method signature doesn't advertise throwing of
DBException.
I have uploaded a new patch. Kindly review.
> LeveldbTimelineStore does not handle db exceptions properly
> -----------------------------------------------------------
>
> Key: YARN-1984
> URL: https://issues.apache.org/jira/browse/YARN-1984
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 2.4.0
> Reporter: Jason Lowe
> Assignee: Varun Saxena
> Fix For: 2.7.0
>
> Attachments: YARN-1984.001.patch, YARN-1984.patch
>
>
> The org.iq80.leveldb.DB and DBIterator methods throw runtime exceptions
> rather than IOException which can easily leak up the stack and kill threads
> (e.g.: the deletion thread).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
