[ 
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225086#comment-14225086
 ] 

Mit Desai commented on YARN-2890:
---------------------------------

I was trying out the fix for MiniMRYarnCluster where we want to start the 
timeline service only if the TIMELINE_SERVICE_ENABLED == true. But as per 
current implementation of the miniCluster, it takes in a boolean when its 
instance is created to decide whether to start or not to start the timeline 
server.
{{public MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS)}}

To me that seems to be a wrong way to start the timeline server. I was thinking 
of removing the flag all together and start the timeline service only if the 
following config is turned on.
{{YarnConfiguration.TIMELINE_SERVICE_ENABLED}}

What do you guys think of it? I am cleaning up my patch and will post it 
shortly so everyone can take a look and provide their feedback.

> MiniMRYarnCluster should turn on timeline service if configured to do so
> ------------------------------------------------------------------------
>
>                 Key: YARN-2890
>                 URL: https://issues.apache.org/jira/browse/YARN-2890
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Mit Desai
>            Assignee: Mit Desai
>             Fix For: 2.6.1
>
>
> Currently the MiniMRYarnCluster does not consider the configuration value for 
> enabling timeline service before starting. The MiniYarnCluster should only 
> start the timeline service if it is configured to do so.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to