[ 
https://issues.apache.org/jira/browse/YARN-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231719#comment-14231719
 ] 

Chun Chen commented on YARN-2674:
---------------------------------

Thanks for review, [~jianhe] , upload a new patch addressing your comments. 

Looking at the patch again, I think other applications using AMRMClientImpl 
might have the same issue if it didn’t explicit call removeContainerRequest. 
IMHO, It is better if we can fix the issue within AMRMClientImpl. Any thoughts?

> Distributed shell AM may re-launch containers if RM work preserving restart 
> happens
> -----------------------------------------------------------------------------------
>
>                 Key: YARN-2674
>                 URL: https://issues.apache.org/jira/browse/YARN-2674
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Chun Chen
>         Attachments: YARN-2674.1.patch, YARN-2674.2.patch
>
>
> Currently, if RM work preserving restart happens while distributed shell is 
> running, distribute shell AM may re-launch all the containers, including 
> new/running/complete. We must make sure it won't re-launch the 
> running/complete containers.
> We need to remove allocated containers from 
> AMRMClientImpl#remoteRequestsTable once AM receive them from RM. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to