[ 
https://issues.apache.org/jira/browse/YARN-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240515#comment-14240515
 ] 

Karthik Kambatla commented on YARN-2618:
----------------------------------------

Looks mostly good. One minor comment - 
DominantResourceCalculator#getResourceAsValue:
# Add a comment to the tune of "lower the rank, more dominant the resource"
# Also add a check rank > 0 and rank < number of resources, otherwise throw 
IllegalArgumentException 

> Avoid over-allocation of disk resources
> ---------------------------------------
>
>                 Key: YARN-2618
>                 URL: https://issues.apache.org/jira/browse/YARN-2618
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wei Yan
>            Assignee: Wei Yan
>         Attachments: YARN-2618-1.patch, YARN-2618-2.patch, YARN-2618-3.patch
>
>
> Subtask of YARN-2139. 
> This should include
> - Add API support for introducing disk I/O as the 3rd type resource.
> - NM should report this information to the RM
> - RM should consider this to avoid over-allocation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to