Karthik Kambatla commented on YARN-2618:

Looks good. Ran findbugs locally, and didn't see any new issues. The tests pass 
locally as well.

bq. If the vdisks in the Resource class represents a share of disk operations, 
can we change the name in the Resource class as well to reflect this(from 
vdisks to something else)?
Spoke to Varun offline. I created a sub-task earlier to revisit the config 
names and it is a blocker for the merge. Let us look into all the configs 
together there. 

+1. Committing this. 

> Avoid over-allocation of disk resources
> ---------------------------------------
>                 Key: YARN-2618
>                 URL: https://issues.apache.org/jira/browse/YARN-2618
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wei Yan
>            Assignee: Wei Yan
>         Attachments: YARN-2618-1.patch, YARN-2618-2.patch, YARN-2618-3.patch, 
> YARN-2618-4.patch, YARN-2618-5.patch
> Subtask of YARN-2139. 
> This should include
> - Add API support for introducing disk I/O as the 3rd type resource.
> - NM should report this information to the RM
> - RM should consider this to avoid over-allocation

This message was sent by Atlassian JIRA

Reply via email to