[ 
https://issues.apache.org/jira/browse/YARN-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241986#comment-14241986
 ] 

Jian He commented on YARN-2920:
-------------------------------


- typo: {{// if we a previously running NM, we need notify scheduler about this 
}}
- we can send an event with a list of nodes
{code}
        if (oldNM != null && rmDispatcher != null) {
          rmDispatcher.getEventHandler().handle(
              new NodeLabelsUpdateSchedulerEvent(nodeId, newLabels));
        }
{code}
- use volatile keyword for the reference?
{code}
labelsRef.set(ImmutableSet.copyOf(labels));
{code}
- how about containers running on a node without label, and now we are adding a 
label
- this condition check is unnecessary
{code}
    if (null == labels) {
      labels = CommonNodeLabelsManager.EMPTY_STRING_SET;
    }
{code}

> CapacityScheduler should be notified when labels on nodes changed
> -----------------------------------------------------------------
>
>                 Key: YARN-2920
>                 URL: https://issues.apache.org/jira/browse/YARN-2920
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-2920.1.patch, YARN-2920.2.patch, YARN-2920.3.patch
>
>
> Currently, labels on nodes changes will only be handled by 
> RMNodeLabelsManager, but that is not enough upon labels on nodes changes:
> - Scheduler should be able to do take actions to running containers. (Like 
> kill/preempt/do-nothing)
> - Used / available capacity in scheduler should be updated for future 
> planning.
> We need add a new event to pass such updates to scheduler



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to