[ 
https://issues.apache.org/jira/browse/YARN-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248296#comment-14248296
 ] 

Hudson commented on YARN-2914:
------------------------------

FAILURE: Integrated in Hadoop-Hdfs-trunk #1975 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1975/])
YARN-2914. [YARN-1492] Potential race condition in Singleton implementation of 
SharedCacheUploaderMetrics, CleanerMetrics, ClientSCMMetrics. (Varun Saxena via 
kasha) (kasha: rev e597249d361bbe8383fb9b564eacda7c990b781d)
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager/src/main/java/org/apache/hadoop/yarn/server/sharedcachemanager/CleanerService.java
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager/src/test/java/org/apache/hadoop/yarn/server/sharedcachemanager/metrics/TestCleanerMetrics.java
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager/src/main/java/org/apache/hadoop/yarn/server/sharedcachemanager/ClientProtocolService.java
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager/src/main/java/org/apache/hadoop/yarn/server/sharedcachemanager/metrics/ClientSCMMetrics.java
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager/src/main/java/org/apache/hadoop/yarn/server/sharedcachemanager/SharedCacheUploaderService.java
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager/src/main/java/org/apache/hadoop/yarn/server/sharedcachemanager/metrics/CleanerMetrics.java
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager/src/main/java/org/apache/hadoop/yarn/server/sharedcachemanager/metrics/SharedCacheUploaderMetrics.java
* hadoop-yarn-project/CHANGES.txt


> Potential race condition in Singleton implementation of 
> SharedCacheUploaderMetrics, CleanerMetrics, ClientSCMMetrics
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2914
>                 URL: https://issues.apache.org/jira/browse/YARN-2914
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.6.0
>            Reporter: Ted Yu
>            Assignee: Varun Saxena
>            Priority: Minor
>             Fix For: 2.7.0
>
>         Attachments: YARN-2914.002.patch, YARN-2914.patch
>
>
> {code}
>   public static ClientSCMMetrics getInstance() {
>     ClientSCMMetrics topMetrics = Singleton.INSTANCE.impl;
>     if (topMetrics == null) {
>       throw new IllegalStateException(
> {code}
> getInstance() doesn't hold lock on Singleton.this
> This may result in IllegalStateException being thrown prematurely.
> [~ctrezzo] reported that SharedCacheUploaderMetrics has also same kind of 
> race condition.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to