[
https://issues.apache.org/jira/browse/YARN-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248556#comment-14248556
]
Varun Saxena commented on YARN-2914:
------------------------------------
Thanks [~kasha] for the review and commit
> Potential race condition in Singleton implementation of
> SharedCacheUploaderMetrics, CleanerMetrics, ClientSCMMetrics
> --------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-2914
> URL: https://issues.apache.org/jira/browse/YARN-2914
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 2.6.0
> Reporter: Ted Yu
> Assignee: Varun Saxena
> Priority: Minor
> Fix For: 2.7.0
>
> Attachments: YARN-2914.002.patch, YARN-2914.patch
>
>
> {code}
> public static ClientSCMMetrics getInstance() {
> ClientSCMMetrics topMetrics = Singleton.INSTANCE.impl;
> if (topMetrics == null) {
> throw new IllegalStateException(
> {code}
> getInstance() doesn't hold lock on Singleton.this
> This may result in IllegalStateException being thrown prematurely.
> [~ctrezzo] reported that SharedCacheUploaderMetrics has also same kind of
> race condition.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
