[ https://issues.apache.org/jira/browse/YARN-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250697#comment-14250697 ]
Ray Chiang commented on YARN-2975: ---------------------------------- For removeNonRunnableApp(), isRunnableApp(), isNonRunnableApp(), shouldn't the return value be in the finally block instead of the try block? > FSLeafQueue app lists are accessed without required locks > --------------------------------------------------------- > > Key: YARN-2975 > URL: https://issues.apache.org/jira/browse/YARN-2975 > Project: Hadoop YARN > Issue Type: Bug > Affects Versions: 2.6.0 > Reporter: Karthik Kambatla > Assignee: Karthik Kambatla > Priority: Blocker > Attachments: yarn-2975-1.patch > > > YARN-2910 adds explicit locked access to runnable and non-runnable apps in > FSLeafQueue. As FSLeafQueue has getters for these, they can be accessed > without locks in other places. -- This message was sent by Atlassian JIRA (v6.3.4#6332)