[ 
https://issues.apache.org/jira/browse/YARN-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250941#comment-14250941
 ] 

Anubhav Dhoot commented on YARN-2975:
-------------------------------------

The removeApp from one operation is now 2 steps.  Just to confirm my 
understanding, are we relying on the locking in FairScheduler's calling methods 
(removeApplicationAttempt etc) to ensure consistency
    boolean wasRunnable = queue.isRunnableApp(attempt);
    queue.removeApp(attempt);

Nit: 
suggest resetPreemptedResources -> resetPreemptedResourcesRunnableApps
clearPreemptedResources -> clear     PreemptedResourcesRunnableApps

> FSLeafQueue app lists are accessed without required locks
> ---------------------------------------------------------
>
>                 Key: YARN-2975
>                 URL: https://issues.apache.org/jira/browse/YARN-2975
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Blocker
>         Attachments: yarn-2975-1.patch
>
>
> YARN-2910 adds explicit locked access to runnable and non-runnable apps in 
> FSLeafQueue. As FSLeafQueue has getters for these, they can be accessed 
> without locks in other places. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to