Anubhav Dhoot commented on YARN-2975:

Minor comment:
The following comment might be misleading. One may assume this means the app 
will be removed regardless and the boolean return is only to indicate whether 
it happened to be nonRunnable
   * @return true if the app was non-runnable, false otherwise
 public boolean removeNonRunnableApp(FSAppAttempt app) {

LGTM otherwise

> FSLeafQueue app lists are accessed without required locks
> ---------------------------------------------------------
>                 Key: YARN-2975
>                 URL: https://issues.apache.org/jira/browse/YARN-2975
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Blocker
>         Attachments: yarn-2975-1.patch, yarn-2975-2.patch
> YARN-2910 adds explicit locked access to runnable and non-runnable apps in 
> FSLeafQueue. As FSLeafQueue has getters for these, they can be accessed 
> without locks in other places. 

This message was sent by Atlassian JIRA

Reply via email to