Anubhav Dhoot commented on YARN-2881:

Hi [~subru] thanks for your review

bq. Are you assuming that parent queue names are unique in FS?
I am assuming the names are all fully qualified, both when clients refer to a 
queue name while managing reservations, and during the implementation of fair 
scheduler's reservation portion. This is in contrast to the 
CapcacityScheduler's reservation portion.
bq. run() need not be synchronized. I know this is from previous code but it 
would be good to clean it up since we are refactoring the code.
AbstractPlanFollower::plans is modified from multiple places and that seems the 
only protection for it.

bq. getChildReservationQueues() could be implemented by the 
AbstractSchedulerPlanFollower using Queue::getQueueInfo ?
That will only give us QueueInfos for the child queues. Rest of the code deals 
in Queue (eg getPlanQueue). So I would prefer leaving this as is.

bq. I think we can add a getResourceCalculator to YarnScheduler as it makes 
sense. Then we need not override calculateTargetCapacity() and 

bq. Minor: spurious white lines in imports of CapacitySchedulerPlanFollower & 

> Implement PlanFollower for FairScheduler
> ----------------------------------------
>                 Key: YARN-2881
>                 URL: https://issues.apache.org/jira/browse/YARN-2881
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: fairscheduler
>            Reporter: Anubhav Dhoot
>            Assignee: Anubhav Dhoot
>         Attachments: YARN-2881.001.patch, YARN-2881.prelim.patch

This message was sent by Atlassian JIRA

Reply via email to