Karthik Kambatla commented on YARN-2881:

In the latest patch, I see that the two methods in FairScheduler are not 
synchronized anymore. Is this because it is okay for setEntitlement to be 
called on a queue which is concurrently removed? 

One last nit: we should try to avoid orphan TODOs. setEntitlement has one. 

> Implement PlanFollower for FairScheduler
> ----------------------------------------
>                 Key: YARN-2881
>                 URL: https://issues.apache.org/jira/browse/YARN-2881
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: fairscheduler
>            Reporter: Anubhav Dhoot
>            Assignee: Anubhav Dhoot
>         Attachments: YARN-2881.001.patch, YARN-2881.002.patch, 
> YARN-2881.002.patch, YARN-2881.003.patch, YARN-2881.004.patch, 
> YARN-2881.005.patch, YARN-2881.006.patch, YARN-2881.prelim.patch

This message was sent by Atlassian JIRA

Reply via email to