[ 
https://issues.apache.org/jira/browse/YARN-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279655#comment-14279655
 ] 

Sangjin Lee commented on YARN-2928:
-----------------------------------

One observation on the code organization. The existing ATS code is actually 
spread out in several places:
- entities, etc. API: {{org.apache.hadoop.yarn.api.records.timeline.\*}} at 
hadoop-yarn-api
- TimelineClient API: {{org.apache.hadoop.yarn.client.api.\*}} at 
hadoop-yarn-common
- server: {{org.apache.hadoop.yarn.server.timeline.\*}} at 
hadoop-yarn-server-applicationhistoryservice

I suppose the reason the client-side API resides in yarn-api and yarn-common 
rather than yarn-client is to accommodate RM's use of ATS?

How should we organize new code? We settled the question on the server piece 
(hadoop-yarn-server-timelineservice), but we need to make a decision on where 
we will put the client and common pieces.

Also, we may want to organize the package names to be coherent. My suggestion 
would be to use
{noformat}
org.apache.hadoop.yarn.[common|client|server].timelineservice.<detailed_subfeature>
{noformat}

For example, the timeline aggregator would go to 
{{org.apache.hadoop.yarn.server.timelineservice.aggregator.\*}}. The timeline 
client API would go to {{org.apache.hadoop.yarn.client.timelineservice.api.\*}}.

What is the best practice in terms of package naming?

> Application Timeline Server (ATS) next gen: phase 1
> ---------------------------------------------------
>
>                 Key: YARN-2928
>                 URL: https://issues.apache.org/jira/browse/YARN-2928
>             Project: Hadoop YARN
>          Issue Type: New Feature
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Vinod Kumar Vavilapalli
>            Priority: Critical
>         Attachments: ATSv2.rev1.pdf, ATSv2.rev2.pdf
>
>
> We have the application timeline server implemented in yarn per YARN-1530 and 
> YARN-321. Although it is a great feature, we have recognized several critical 
> issues and features that need to be addressed.
> This JIRA proposes the design and implementation changes to address those. 
> This is phase 1 of this effort.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to