[ 
https://issues.apache.org/jira/browse/YARN-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279916#comment-14279916
 ] 

Zhijie Shen commented on YARN-2928:
-----------------------------------

bq. I suppose the reason the client-side API resides in yarn-api and 
yarn-common rather than yarn-client is to accommodate RM's use of ATS?

Right, this is because we want to prevent cyclic dependency issue (RM -> ATS -> 
server-tests -> RM). Another issue is TimelineDelegationToken#renewer inside 
common module is using timeline client too. YARN-2506 is investigating the 
solution to correct the packaging.

bq.  but we need to make a decision on where we will put the client and common 
pieces.

IMHO, common code goes to hadoop-yarn-common (or hadoop-yarn-api if it's API 
related). If we can prevent cyclic dependency, the client code is best to be in 
hadoop-yarn-client.

bq. My suggestion would be to use

The package naming looks good. However, there are already some conventions. For 
example, all client libs are under {{org.apache.hadoop.yarn.client.api}}. It 
may be better to keep to it. As to the common code, I saw the style in 
hadoop-yarn-common is {{org.apache.hadoop.yarn.\[feature name\]}}. Finally, the 
server code doesn't have "server" in the package name.  It may be organized 
like {{org.apache.hadoop.yarn.timelineservice.aggregator.*}}


> Application Timeline Server (ATS) next gen: phase 1
> ---------------------------------------------------
>
>                 Key: YARN-2928
>                 URL: https://issues.apache.org/jira/browse/YARN-2928
>             Project: Hadoop YARN
>          Issue Type: New Feature
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Vinod Kumar Vavilapalli
>            Priority: Critical
>         Attachments: ATSv2.rev1.pdf, ATSv2.rev2.pdf
>
>
> We have the application timeline server implemented in yarn per YARN-1530 and 
> YARN-321. Although it is a great feature, we have recognized several critical 
> issues and features that need to be addressed.
> This JIRA proposes the design and implementation changes to address those. 
> This is phase 1 of this effort.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to