[
https://issues.apache.org/jira/browse/YARN-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287871#comment-14287871
]
Sandy Ryza commented on YARN-2990:
----------------------------------
Other than the addition of the anyLocalRequests check core here:
{code}
+ if (offSwitchRequest.getNumContainers() > 0 &&
+ (!anyLocalRequests(priority)
+ || allowedLocality.equals(NodeType.OFF_SWITCH))) {
{code}
are the other changes core to the fix? If not, given that this is touchy code,
can we leave things the way they are or make the changes in a separate cleanup
JIRA?
Also, a couple nits:
* Need some extra indentation in the snippet above
* "anyLocalRequests" is kind of a confusing name for that method, because "any"
often means "off-switch" when thinking about locality. Maybe
"hasNodeOrRackRequests".
> FairScheduler's delay-scheduling always waits for node-local and rack-local
> delays, even for off-rack-only requests
> -------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-2990
> URL: https://issues.apache.org/jira/browse/YARN-2990
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler
> Affects Versions: 2.6.0
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: yarn-2990-0.patch, yarn-2990-1.patch,
> yarn-2990-test.patch
>
>
> Looking at the FairScheduler, it appears the node/rack locality delays are
> used for all requests, even those that are only off-rack.
> More details in comments.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
