[jira] [Commented] (YARN-3098) Create common QueueCapacities class in Capacity Scheduler to track capacities-by-labels of queues

[Jian He (JIRA)]

    [ 
https://issues.apache.org/jira/browse/YARN-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292566#comment-14292566
 ] 

Jian He commented on YARN-3098:
-------------------------------

- maybe a bug ? it's internally using NL
{code}
  public void setUsedCapacity(String label, float value) {
    try {
      writeLock.lock();
      Capacities cap = capacitiesMap.get(NL);
{code}
- {{ public float getAbsoluteUsedCapacity() }}, the implementation can be 
{{getAbsoluteUsedCapacity(NL)}}
- maybe have a generic getter/setter and try parametrizing the capacity type to 
avoid duplication. 

> Create common QueueCapacities class in Capacity Scheduler to track 
> capacities-by-labels of queues
> -------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3098
>                 URL: https://issues.apache.org/jira/browse/YARN-3098
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-3098.1.patch
>
>
> Similar to YARN-3092, after YARN-796, now queues (ParentQueue and LeafQueue) 
> need to track capacities-label (e.g. absolute-capacity, maximum-capacity, 
> absolute-capacity, absolute-maximum-capacity, etc.). It's better to have a 
> class to encapsulate these capacities to make both better 
> maintainability/readability and fine-grained locking.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)