[ 
https://issues.apache.org/jira/browse/YARN-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294225#comment-14294225
 ] 

Ming Ma commented on YARN-2980:
-------------------------------

[~varun_saxena], sorry for the late response. Couple comments:

1. It will be useful if we can have some unit test for 
{{NodeHealthScriptRunner}} under hadoop-common-project. Maybe we can move 
{{TestNodeHealthService}} from hadoop-yarn.
2. {{NodeHealthStatus}} seems general. For HDFS NN's health check, this object 
could be handy if we want to show the health check on NN webUI. More 
interesting case is health check for HDFS DN; this structure can be reused for 
RPC between DN and NN. We can use another jira for that, move 
{{NodeHealthStatus}} and the protobuf defintion to hadoop-common.
3. HDFS so far hasn't used AbstractService. NodeHealthScriptRunner will be the 
first. That seems ok. Still, raise the point in case.

> Move health check script related functionality to hadoop-common
> ---------------------------------------------------------------
>
>                 Key: YARN-2980
>                 URL: https://issues.apache.org/jira/browse/YARN-2980
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Ming Ma
>            Assignee: Varun Saxena
>         Attachments: YARN-2980.001.patch, YARN-2980.002.patch
>
>
> HDFS might want to leverage health check functionality available in YARN in 
> both namenode https://issues.apache.org/jira/browse/HDFS-7400 and datanode 
> https://issues.apache.org/jira/browse/HDFS-7441.
> We can move health check functionality including the protocol between hadoop 
> daemons and health check script to hadoop-common. That will simplify the 
> development and maintenance for both hadoop source code and health check 
> script.
> Thoughts?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to