[ 
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294441#comment-14294441
 ] 

Craig Welch commented on YARN-2495:
-----------------------------------

[~Naganarasimha] I understand the desire to have the feature, it does seem more 
like a convenience / simplification measure than an introduction of something 
that can't be otherwise accomplished, but convenience and simplification can 
matter a great deal, so why not :-)

bq. There will be always confusion ... Do we need to "And" or "OR" 

What I'm getting at is that I think there are just too many switches and knobs 
in play once you consider the flag DECENTRALIZED_CONFIGURATION_ENABLED in 
addition to the other configuration relationships (defining the configuration 
script to do the update from nodes), I think that the act of configuring 
something to send node labels from the node manager is sufficient "intent" that 
it is the desired behavior, and the additional  
DECENTRALIZED_CONFIGURATION_ENABLED is just an extra ceiling for someone to 
bump their head against while setting this up.  wrt supporting add vs replace 
behavior, I think that as it's described now the idea is to just support 
replace form the node script, meaning that it will effectively be the only 
definition used when it is active (which is fine for many cases).  In the 
future, if there is a need for hybrid configuration of labels that can become 
an enhancement.  An option would be to use a different parameter for a script 
which will do add and remove instead of replace, and then say have it return + 
or - (for add and remove) with the label instead of a fixed set of labels for 
replacement.  From what I see above, the replacement approach, where the script 
determines the full label set, looks to be the immediate need - the other could 
be added in a compatible way later if it was needed.

> Allow admin specify labels from each NM (Distributed configuration)
> -------------------------------------------------------------------
>
>                 Key: YARN-2495
>                 URL: https://issues.apache.org/jira/browse/YARN-2495
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>         Attachments: YARN-2495.20141023-1.patch, YARN-2495.20141024-1.patch, 
> YARN-2495.20141030-1.patch, YARN-2495.20141031-1.patch, 
> YARN-2495.20141119-1.patch, YARN-2495.20141126-1.patch, 
> YARN-2495.20141204-1.patch, YARN-2495.20141208-1.patch, 
> YARN-2495_20141022.1.patch
>
>
> Target of this JIRA is to allow admin specify labels in each NM, this covers
> - User can set labels in each NM (by setting yarn-site.xml (YARN-2923) or 
> using script suggested by [~aw] (YARN-2729) )
> - NM will send labels to RM via ResourceTracker API
> - RM will set labels in NodeLabelManager when NM register/update labels



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to