[ 
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328370#comment-14328370
 ] 

Wangda Tan commented on YARN-2495:
----------------------------------

[~cwelch],
Thanks for your thoughtful inputs, configuration switches include changes 
proposed in this patch is:
{code}
                  node-label
                   /     \
              enable     disable
             /      \
    centralized     distributed
         |                  |
 node-label-store          node-manager script
 need to be configured     need to be configured in NM
{code}

You can take a look at discussion of why we do YARN-2800, we need 
enable/disable this feature (not enable/disable centralized API).
And there're some difference between centralized/distributed configure
- We don't need to store node->label mappings since NM will store it locally
- We cannot mix them together as I mentioned in 
https://issues.apache.org/jira/browse/YARN-2495?focusedCommentId=14317048&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14317048.

So there're totally 3 options of node-label feature itself in RM's view: 
\{disabled, centralized, distributed\}. I don't think we can eliminate any of 
them, and I didn't see your suggestion can make it :).

So if you agree, I suggest we can move forward this with following changes:
- Change {{decentralized-configuration.enabled}} to {{input}}, accept value of 
\{centralized, distributed\} (by default is centralized)
- Combining suggestion in 
https://issues.apache.org/jira/browse/YARN-2495?focusedCommentId=14317048&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14317048.
- Not sure if https://issues.apache.org/jira/browse/YARN-2980 will impact 
implementation of this patch (I haven't looked at it), but it's best to reusage 
existing code.

Sounds good? [~Naganarasimha] please let me know if you have any other ideas :).

> Allow admin specify labels from each NM (Distributed configuration)
> -------------------------------------------------------------------
>
>                 Key: YARN-2495
>                 URL: https://issues.apache.org/jira/browse/YARN-2495
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>         Attachments: YARN-2495.20141023-1.patch, YARN-2495.20141024-1.patch, 
> YARN-2495.20141030-1.patch, YARN-2495.20141031-1.patch, 
> YARN-2495.20141119-1.patch, YARN-2495.20141126-1.patch, 
> YARN-2495.20141204-1.patch, YARN-2495.20141208-1.patch, 
> YARN-2495_20141022.1.patch
>
>
> Target of this JIRA is to allow admin specify labels in each NM, this covers
> - User can set labels in each NM (by setting yarn-site.xml (YARN-2923) or 
> using script suggested by [~aw] (YARN-2729) )
> - NM will send labels to RM via ResourceTracker API
> - RM will set labels in NodeLabelManager when NM register/update labels



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to