Hadoop QA commented on YARN-3160:

{color:red}-1 overall{color}.  Here are the results of testing the latest 
  against trunk revision 4eb5f7f.

    {color:green}+1 @author{color}.  The patch does not contain any @author 

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 

Test results: 
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6578//console

This message is automatically generated.

> Non-atomic operation on nodeUpdateQueue in RMNodeImpl
> -----------------------------------------------------
>                 Key: YARN-3160
>                 URL: https://issues.apache.org/jira/browse/YARN-3160
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.7.0
>            Reporter: Chengbing Liu
>            Assignee: Chengbing Liu
>         Attachments: YARN-3160.2.patch, YARN-3160.patch
> {code:title=RMNodeImpl.java|borderStyle=solid}
> while(nodeUpdateQueue.peek() != null){
>   latestContainerInfoList.add(nodeUpdateQueue.poll());
> }
> {code}
> The above code brings potential risk of adding null value to 
> {{latestContainerInfoList}}. Since {{ConcurrentLinkedQueue}} implements a 
> wait-free algorithm, we can directly poll the queue, before checking whether 
> the value is null.

This message was sent by Atlassian JIRA

Reply via email to