[ https://issues.apache.org/jira/browse/YARN-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316324#comment-14316324 ]
Hudson commented on YARN-3160: ------------------------------ FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #102 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/102/]) YARN-3160. Fix non-atomic operation on nodeUpdateQueue in RMNodeImpl. (Contributed by Chengbing Liu) (junping_du: rev c541a374d88ffed6ee71b0e5d556939ccd2c5159) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java * hadoop-yarn-project/CHANGES.txt > Non-atomic operation on nodeUpdateQueue in RMNodeImpl > ----------------------------------------------------- > > Key: YARN-3160 > URL: https://issues.apache.org/jira/browse/YARN-3160 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager > Affects Versions: 2.7.0 > Reporter: Chengbing Liu > Assignee: Chengbing Liu > Fix For: 2.7.0 > > Attachments: YARN-3160.2.patch, YARN-3160.patch > > > {code:title=RMNodeImpl.java|borderStyle=solid} > while(nodeUpdateQueue.peek() != null){ > latestContainerInfoList.add(nodeUpdateQueue.poll()); > } > {code} > The above code brings potential risk of adding null value to > {{latestContainerInfoList}}. Since {{ConcurrentLinkedQueue}} implements a > wait-free algorithm, we can directly poll the queue, before checking whether > the value is null. -- This message was sent by Atlassian JIRA (v6.3.4#6332)