Sangjin Lee commented on YARN-3047:

[~varun_saxena], sorry for the late reply. The following are some high level 

(1) could you please add @Private and @Unstable annotations to all non-test 
(2) many of the methods in ApplicationHistoryTimelineManager, 
TimelineReaderWebServices, and TimelineReaderManager can be commented out as 
they need to be reworked based on the queries and the data model anyway

(3) ApplicationHistoryTimelineManager
- name: it's rather awkward to name it ApplicationHistoryTimelineManager; 
"Application" and "History" shouldn't be part of the name; better name?
- I assume "implements ApplicationHistoryManager" was copied over? do we need 

(4) TimelineReaderManager
- do we need both ApplicationHistoryTimelineManager and TimelineReaderManager? 
the distinction between the two doesn't seem clear to me; what role are they 
supposed to serve respectively?

(5) TimelineReaderWebServices
- how about a singular (TimelineReaderWebService)? we used a singular for the 
timeline aggregator

> set up ATS reader with basic request serving structure and lifecycle
> --------------------------------------------------------------------
>                 Key: YARN-3047
>                 URL: https://issues.apache.org/jira/browse/YARN-3047
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>         Attachments: YARN-3047.001.patch
> Per design in YARN-2938, set up the ATS reader as a service and implement the 
> basic structure as a service. It includes lifecycle management, request 
> serving, and so on.

This message was sent by Atlassian JIRA

Reply via email to