Junping Du commented on YARN-2079:

Thanks [~jlowe] for addressing my comments in 003 patch.
bq. ScheduledThreadPoolExecutor already treats negative delays as delays of 
zero, so I didn't bother to replicate that logic.
Make sense. We can just keep it as it is now. However, it could be slightly 
better if we log the minus value to notify that deletion get delayed because of 
NM restart. Isn't it? Anyway, I think this is only a nit and we can fix it 

003 patch looks pretty good to me. [~rohithsharma], do you have additional 
comments here? If not, I will go ahead to commit this.

> Recover NonAggregatingLogHandler state upon nodemanager restart
> ---------------------------------------------------------------
>                 Key: YARN-2079
>                 URL: https://issues.apache.org/jira/browse/YARN-2079
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>    Affects Versions: 2.4.0
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>         Attachments: YARN-2079.002.patch, YARN-2079.003.patch, YARN-2079.patch
> The state of NonAggregatingLogHandler needs to be persisted so logs are 
> properly deleted across a nodemanager restart.

This message was sent by Atlassian JIRA

Reply via email to