[
https://issues.apache.org/jira/browse/YARN-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325139#comment-14325139
]
Zhijie Shen commented on YARN-3207:
-----------------------------------
Varun, thanks for reassign it back to me. I'm currently working on this issue.
bq. Also can there be a possibility that a given secondary filter key is
present in both other info and primary filters,
Practically, if the user put some info in primary filter, it should be put into
other info of the entity again. "primary filter" is somehow a special info, but
will be used as the index.
If the user put the same info in both primary filter and other info, and make
the value null, it will return false, but it's more like a fault use case,
isn't it?
> secondary filter matches entites which do not have the key being filtered for.
> ------------------------------------------------------------------------------
>
> Key: YARN-3207
> URL: https://issues.apache.org/jira/browse/YARN-3207
> Project: Hadoop YARN
> Issue Type: Bug
> Components: timelineserver
> Reporter: Prakash Ramachandran
> Assignee: Zhijie Shen
>
> in the leveldb implementation of the TimelineStore the secondary filter
> matches entities where the key being searched for is not present.
> ex query from tez ui
> http://uvm:8188/ws/v1/timeline/TEZ_DAG_ID/?limit=1&secondaryFilter=foo:bar
> will match and return the entity even though there is no entity with
> otherinfo.foo defined.
> the issue seems to be in
> {code:title=LeveldbTimelineStore:675}
> if (vs != null && !vs.contains(filter.getValue())) {
> filterPassed = false;
> break;
> }
> {code}
> this should be IMHO
> vs == null || !vs.contains(filter.getValue())
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
