[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353383#comment-14353383
]
Vinod Kumar Vavilapalli commented on YARN-2495:
-----------------------------------------------
Quick comments
- configuration.type -> configuration-type
- Should RegisterNodeManagerRequestProto.nodeLabels be a set instead?
- Do we really need NodeHeartbeatRequest.areNodeLabelsSetInReq()? Why not just
look at the set as mentioned in the previous comment?
- RegisterNodeManagerRequest is getting changed. It will be interesting to
reason about rolling-upgrades in this scenario.
- How about we simply things? Instead of accepting labels on both registration
and heartbeat, why not restrict it to be just during registration?
- We should not even accept a node's registration when it reports invalid
labels?
> Allow admin specify labels from each NM (Distributed configuration)
> -------------------------------------------------------------------
>
> Key: YARN-2495
> URL: https://issues.apache.org/jira/browse/YARN-2495
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Wangda Tan
> Assignee: Naganarasimha G R
> Attachments: YARN-2495.20141023-1.patch, YARN-2495.20141024-1.patch,
> YARN-2495.20141030-1.patch, YARN-2495.20141031-1.patch,
> YARN-2495.20141119-1.patch, YARN-2495.20141126-1.patch,
> YARN-2495.20141204-1.patch, YARN-2495.20141208-1.patch,
> YARN-2495.20150305-1.patch, YARN-2495.20150309-1.patch,
> YARN-2495_20141022.1.patch
>
>
> Target of this JIRA is to allow admin specify labels in each NM, this covers
> - User can set labels in each NM (by setting yarn-site.xml (YARN-2923) or
> using script suggested by [~aw] (YARN-2729) )
> - NM will send labels to RM via ResourceTracker API
> - RM will set labels in NodeLabelManager when NM register/update labels
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
