[
https://issues.apache.org/jira/browse/YARN-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336770#comment-14336770
]
Tsuyoshi Ozawa commented on YARN-3248:
--------------------------------------
[~vvasudev] Thanks for taking this issue. This change looks very useful. I have
some comments against 1st patch:
The blacklist is an instance of HashSet, so it can throw
ConcurrentModificationException when blacklist is modified in another thread.
One alternative is to use Collections.newSetFromMap(new
ConcurrentHashMap<Object,Boolean>()) instead of HashSet.
{code}
+ public Set<String> getBlacklistedNodes() {
+ return this.appSchedulingInfo.getBlackList();
+ }
{code}
If AbstractYarnScheduler#getApplicationAttempt() can be used, I think it's more
straightforward and simple. What do you think?
{code}
+ private CapacityScheduler scheduler = null;
{code}
Could you add tests to TestRMWebServicesApps?
> Display count of nodes blacklisted by apps in the web UI
> --------------------------------------------------------
>
> Key: YARN-3248
> URL: https://issues.apache.org/jira/browse/YARN-3248
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: capacityscheduler, resourcemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: Screenshot.jpg, apache-yarn-3248.0.patch
>
>
> It would be really useful when debugging app performance and failure issues
> to get a count of the nodes blacklisted by individual apps displayed in the
> web UI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
