[ 
https://issues.apache.org/jira/browse/YARN-3210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343593#comment-14343593
 ] 

Vinod Kumar Vavilapalli commented on YARN-3210:
-----------------------------------------------

The REST server should be inside TimelineAggregatorsCollection. That way it can 
be used even for Aggregators-in-a-special container.

bq. Shall we call AppLevelTimelineAggregatorsCollection instead of 
TimelineAggregatorsCollection? Looking into the detail, it's not the collection 
of any aggregator that extends BaseTimelineAggregator, but the particular 
AppLevelTimelineAggregator.
We can instead make BaseTimelineAggregator as an abstract class and rename it 
simply to be TimelineAggregator. Then TimelineAggregatorsCollection is a 
collection of TimelineAggregator objects, as it should be.

> [Source organization] Refactor timeline aggregator according to new code 
> organization
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-3210
>                 URL: https://issues.apache.org/jira/browse/YARN-3210
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Li Lu
>            Assignee: Li Lu
>              Labels: refactor
>         Attachments: YARN-3210-022715.patch
>
>
> We may want to refactor the code of timeline aggregator according to the 
> discussion of YARN-3166, the code organization for timeline service v2. We 
> need to refactor the code after we reach an agreement on the aggregator part 
> of YARN-3166. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to