[
https://issues.apache.org/jira/browse/YARN-3210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351113#comment-14351113
]
Sangjin Lee commented on YARN-3210:
-----------------------------------
Thanks [~gtCarrera9] for working on this!
I know it's too late for a code review, but a couple of comments post-commit:
- I'm not too sure if I like the name "PerNodeTimelineAggregatorAuxService".
Yes, it's currently an auxiliary service to the NM, but it can easily be
started up as a standalone daemon. It seems to me that the name appears to
suggest the only way to use it is an auxiliary service. Perhaps we can revisit
this name later?
- minor but TimelineAggregatorWebService has a wildcard import (l.23)
> [Source organization] Refactor timeline aggregator according to new code
> organization
> -------------------------------------------------------------------------------------
>
> Key: YARN-3210
> URL: https://issues.apache.org/jira/browse/YARN-3210
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Li Lu
> Assignee: Li Lu
> Labels: refactor
> Fix For: YARN-2928
>
> Attachments: YARN-3210-022715.patch, YARN-3210-030215.patch,
> YARN-3210-030215_1.patch, YARN-3210-030215_2.patch
>
>
> We may want to refactor the code of timeline aggregator according to the
> discussion of YARN-3166, the code organization for timeline service v2. We
> need to refactor the code after we reach an agreement on the aggregator part
> of YARN-3166.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
