Junping Du commented on YARN-3039:

[~sjlee0], Thanks for comments here! In my understanding, if 
timelineServiceAddress is not null, the pollTimelineServiceAddress() can be 
fast return as below. Isn't it? Do you think we still need a null check here?
  private int pollTimelineServiceAddress(int retries) {
    while (timelineServiceAddress == null && retries > 0) {
      try {
      } catch (InterruptedException e) {
      timelineServiceAddress = getTimelineServiceAddress();
    return retries;

> [Aggregator wireup] Implement ATS app-appgregator service discovery
> -------------------------------------------------------------------
>                 Key: YARN-3039
>                 URL: https://issues.apache.org/jira/browse/YARN-3039
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Junping Du
>         Attachments: Service Binding for applicationaggregator of ATS 
> (draft).pdf, Service Discovery For Application Aggregator of ATS (v2).pdf, 
> YARN-3039-no-test.patch, YARN-3039-v2-incomplete.patch, 
> YARN-3039-v3-core-changes-only.patch, YARN-3039-v4.patch, YARN-3039-v5.patch
> Per design in YARN-2928, implement ATS writer service discovery. This is 
> essential for off-node clients to send writes to the right ATS writer. This 
> should also handle the case of AM failures.

This message was sent by Atlassian JIRA

Reply via email to