[ https://issues.apache.org/jira/browse/YARN-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360605#comment-14360605 ]
Zhijie Shen commented on YARN-2854: ----------------------------------- Hi Naga, thanks for updating the patch. Almost good to me. Some additional comments. 1. Format is wrong around the following sentence (from the built web page). It seems to be the problem of quote mark. Would you please double check? {code} Developers can define what information they want to record for their applications by composing `TimelineEntity and `TimelineEvent` objects, and put the entities and events to the Timeline server via `TimelineClient`. Below is an example: {code} 2. Changing "Publishing of per-framework data by applications" to "Publishing of application-specific data"? 3. In Current Status, shall we also mention " we're rolling out the timeline service next generation" as a scalable solution? > The document about timeline service and generic service needs to be updated > --------------------------------------------------------------------------- > > Key: YARN-2854 > URL: https://issues.apache.org/jira/browse/YARN-2854 > Project: Hadoop YARN > Issue Type: Bug > Components: timelineserver > Reporter: Zhijie Shen > Assignee: Naganarasimha G R > Priority: Critical > Attachments: TimelineServer.html, YARN-2854.20141120-1.patch, > YARN-2854.20150128.1.patch, YARN-2854.20150304.1.patch, > YARN-2854.20150311-1.patch, timeline_structure.jpg > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)