[
https://issues.apache.org/jira/browse/YARN-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363742#comment-14363742
]
Junping Du commented on YARN-3034:
----------------------------------
Thanks [~Naganarasimha] for updating the patch and [~gtCarrera9] for review and
verifying tests there!
bq. One more general comment is, after we introduce the
TIMELINE_SERVICE_VERSION setting, we may want to change the distributed shell
to use it? I think we no longer need the temporary timeline service setting
after we have this setting. We may also need to change TestDistributedShell to
reflect this.
I think in prospective of rolling upgrade, we may support both v1 and v2
timeline services in next several releases. It means the old running
applications still can push left events/metrics to v1 timeline server while new
application can leverage the v2 service after rolling upgrade. RM case is a
little different, it may leverage new timeline service after being upgraded so
involving a version configuration here sounds reasonable to me. This version in
RM side should be separated with AM where another version will get passed (by
application config or command line parameter) in, so Distributed Shell AM and
test should still be fine after this patch in.
Additional two comments on the patch:
1. We should put new added version property in yarn-default.xml and add a
description there.
2. I didn't see any test with enabling v2 version in RM side for publishing RM
metrics to v2 timeline service. Because we have a end-to-end test in
TestDistributedShell now, it would be great if we can leverage it and publish
some contents from RM and verify there.
> [Aggregator wireup] Implement RM starting its ATS writer
> --------------------------------------------------------
>
> Key: YARN-3034
> URL: https://issues.apache.org/jira/browse/YARN-3034
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Sangjin Lee
> Assignee: Naganarasimha G R
> Attachments: YARN-3034-20150312-1.patch, YARN-3034.20150205-1.patch,
> YARN-3034.20150316-1.patch
>
>
> Per design in YARN-2928, implement resource managers starting their own ATS
> writers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
