[ 
https://issues.apache.org/jira/browse/YARN-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14364198#comment-14364198
 ] 

Jian He commented on YARN-3039:
-------------------------------

Here, we should not save the current app state in state-store, otherwise 
recovery logic will break - it's currently not expecting non-final state on 
recovery.
{code}
      // Save to RMStateStore
      ApplicationStateData appState = ApplicationStateData.newInstance(
          app.getSubmitTime(), app.getStartTime(),app.getUser(),
          app.getApplicationSubmissionContext(), app.getState(), 
          app.getDiagnostics().toString(), app.getFinishTime(), 
app.getAggregatorAddr());
      app.rmContext.getStateStore().updateApplicationState(appState);
{code}

> [Aggregator wireup] Implement ATS app-appgregator service discovery
> -------------------------------------------------------------------
>
>                 Key: YARN-3039
>                 URL: https://issues.apache.org/jira/browse/YARN-3039
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Junping Du
>         Attachments: Service Binding for applicationaggregator of ATS 
> (draft).pdf, Service Discovery For Application Aggregator of ATS (v2).pdf, 
> YARN-3039-no-test.patch, YARN-3039-v2-incomplete.patch, 
> YARN-3039-v3-core-changes-only.patch, YARN-3039-v4.patch, YARN-3039-v5.patch
>
>
> Per design in YARN-2928, implement ATS writer service discovery. This is 
> essential for off-node clients to send writes to the right ATS writer. This 
> should also handle the case of AM failures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to