[
https://issues.apache.org/jira/browse/YARN-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377204#comment-14377204
]
Xuan Gong commented on YARN-3393:
---------------------------------
+1 LGTM. Will commit
> Getting application(s) goes wrong when app finishes before starting the
> attempt
> -------------------------------------------------------------------------------
>
> Key: YARN-3393
> URL: https://issues.apache.org/jira/browse/YARN-3393
> Project: Hadoop YARN
> Issue Type: Bug
> Components: timelineserver
> Reporter: Zhijie Shen
> Assignee: Zhijie Shen
> Priority: Critical
> Attachments: YARN-3393.1.patch
>
>
> When generating app report in ApplicationHistoryManagerOnTimelineStore, it
> checks if appAttempt == null.
> {code}
> ApplicationAttemptReport appAttempt =
> getApplicationAttempt(app.appReport.getCurrentApplicationAttemptId());
> if (appAttempt != null) {
> app.appReport.setHost(appAttempt.getHost());
> app.appReport.setRpcPort(appAttempt.getRpcPort());
> app.appReport.setTrackingUrl(appAttempt.getTrackingUrl());
>
> app.appReport.setOriginalTrackingUrl(appAttempt.getOriginalTrackingUrl());
> }
> {code}
> However, {{getApplicationAttempt}} doesn't return null but throws
> ApplicationAttemptNotFoundException:
> {code}
> if (entity == null) {
> throw new ApplicationAttemptNotFoundException(
> "The entity for application attempt " + appAttemptId +
> " doesn't exist in the timeline store");
> } else {
> return convertToApplicationAttemptReport(entity);
> }
> {code}
> They code isn't coupled well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
