[ 
https://issues.apache.org/jira/browse/YARN-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482248#comment-14482248
 ] 

Junping Du commented on YARN-1376:
----------------------------------

Hi [~xgong], thanks for the patch! 
Some major comments after going through the patch here:
- Shall we put LogAggregationStatus and LogAggregationReport (and related pb 
impl) on server-api instead of yarn api? We will not expose it to application, 
so better to put in server side.
- I didn't see where we remove element from logAggregationReportForApps. I 
think we need to remove it when log aggregation finished or it will still 
occupy (and may eat up gradually) NM's memory.


> NM need to notify the log aggregation status to RM through Node heartbeat
> -------------------------------------------------------------------------
>
>                 Key: YARN-1376
>                 URL: https://issues.apache.org/jira/browse/YARN-1376
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-1376.1.patch, YARN-1376.2.patch, YARN-1376.2.patch, 
> YARN-1376.2015-04-04.patch, YARN-1376.2015-04-06.patch, YARN-1376.3.patch, 
> YARN-1376.4.patch
>
>
> Expose a client API to allow clients to figure if log aggregation is 
> complete. The ticket is used to track the changes on NM side



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to