Junping Du commented on YARN-1376:

bq. I didn't see where we remove element from logAggregationReportForApps. I 
think we need to remove it when log aggregation finished or it will still 
occupy (and may eat up gradually) NM's memory.
Just synced with [~xgong] offline that we do poll operation on 
logAggregationReportForApps, so element should get removed from 
ConcurrentLinkedQueue, so my previous comments is not valid here. However, 
there is a case we need pay attention that if heartbeat request is not getting 
respond, we shouldn't poll the aggregation report directly. Instead, we could 
put polled element to some temporary list, then drop it if get response 
successfully or merge it back to LinkedQueue for next time heartbeat. 

> NM need to notify the log aggregation status to RM through Node heartbeat
> -------------------------------------------------------------------------
>                 Key: YARN-1376
>                 URL: https://issues.apache.org/jira/browse/YARN-1376
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-1376.1.patch, YARN-1376.2.patch, YARN-1376.2.patch, 
> YARN-1376.2015-04-04.patch, YARN-1376.2015-04-06.patch, YARN-1376.3.patch, 
> YARN-1376.4.patch
> Expose a client API to allow clients to figure if log aggregation is 
> complete. The ticket is used to track the changes on NM side

This message was sent by Atlassian JIRA

Reply via email to