[
https://issues.apache.org/jira/browse/YARN-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492951#comment-14492951
]
Nathan Roberts commented on YARN-3361:
--------------------------------------
Hi [~leftnoteasy].
One comment/question. There are several places in computeUserLimit() that pass
clusterResource to the resourceCalculator. This is used in the
dominantResourceFirst calculations when determining which sub-component of the
resource is dominant. However, a resource that is dominant for the cluster
(clusterResource), may not be the dominant resource for the partition currently
being evaluated. Couldn't this break dominant resource assumptions?
Example:
{code}
Resource currentCapacity =
Resources.lessThan(resourceCalculator, clusterResource,
queueUsage.getUsed(nodePartition), queueCapacity) ? queueCapacity
: Resources.add(queueUsage.getUsed(nodePartition), required);
{code}
> CapacityScheduler side changes to support non-exclusive node labels
> -------------------------------------------------------------------
>
> Key: YARN-3361
> URL: https://issues.apache.org/jira/browse/YARN-3361
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacityscheduler
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-3361.1.patch, YARN-3361.10.patch,
> YARN-3361.2.patch, YARN-3361.3.patch, YARN-3361.4.patch, YARN-3361.5.patch,
> YARN-3361.6.patch, YARN-3361.7.patch, YARN-3361.8.patch, YARN-3361.9.patch
>
>
> According to design doc attached in YARN-3214, we need implement following
> logic in CapacityScheduler:
> 1) When allocate a resource request with no node-label specified, it should
> get preferentially allocated to node without labels.
> 2) When there're some available resource in a node with label, they can be
> used by applications with following order:
> - Applications under queues which can access the label and ask for same
> labeled resource.
> - Applications under queues which can access the label and ask for
> non-labeled resource.
> - Applications under queues cannot access the label and ask for non-labeled
> resource.
> 3) Expose necessary information that can be used by preemption policy to make
> preemption decisions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
