Junping Du commented on YARN-3046:

bq. In the new patch, the task entity ID is set correctly. But can we use 
reflect or make "getTaskId" the interface method of TaskEvent to simply the 
code change?
I agree that it could make code more concisely if we can differentiate job 
entities from task entities with refection or some other ways. Coincidentally, 
I also put some ideas and comments to MAPREDUCE-6318. However, can we do this 
refactor together with v1 timeline service in MAPREDUCE-6318? The code here far 
more than acceptable, I believe.

> [Event producers] Implement MapReduce AM writing some MR metrics to ATS
> -----------------------------------------------------------------------
>                 Key: YARN-3046
>                 URL: https://issues.apache.org/jira/browse/YARN-3046
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Junping Du
>         Attachments: YARN-3046-no-test-v2.patch, YARN-3046-no-test.patch, 
> YARN-3046-v1-rebase.patch, YARN-3046-v1.patch, YARN-3046-v2.patch, 
> YARN-3046-v3.patch
> Per design in YARN-2928, select a handful of MR metrics (e.g. HDFS bytes 
> written) and have the MR AM write the framework-specific metrics to ATS.

This message was sent by Atlassian JIRA

Reply via email to