[ 
https://issues.apache.org/jira/browse/YARN-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506118#comment-14506118
 ] 

Wangda Tan commented on YARN-3523:
----------------------------------

[~Naganarasimha], thanks for taking this.
Actually I'm not sure about what should be the correct audience setting for 
ResourceManagerAdministrationProtocol, as a public API, it should be @Public. 
But actually, it will only used by RMAdminCLI, I don't know is there any 3rd 
party projects writing their own "admin CLI" and implements 
ResourceManagerAdministrationProtocol.

To not break compatibility, I think simple solution is to only change 
ResourceManagerAdministrationProtocol from @Private to @Public. I don't know if 
there's any thoughts about this.

> Cleanup ResourceManagerAdministrationProtocol interface audience
> ----------------------------------------------------------------
>
>                 Key: YARN-3523
>                 URL: https://issues.apache.org/jira/browse/YARN-3523
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>
> I noticed ResourceManagerAdministrationProtocol has @Private audience for the 
> class and @Public audience for methods. It doesn't make sense to me. We 
> should make class audience and methods audience consistent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to