[ https://issues.apache.org/jira/browse/YARN-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528034#comment-14528034 ]
Hadoop QA commented on YARN-3523: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 15m 12s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | | {color:green}+1{color} | javac | 7m 53s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 10m 0s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 1m 6s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 35s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 28s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. | | {color:green}+1{color} | yarn tests | 0m 26s | Tests passed in hadoop-yarn-api. | | | | 38m 38s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12730378/YARN-3523.20150505-1.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 318081c | | hadoop-yarn-api test log | https://builds.apache.org/job/PreCommit-YARN-Build/7703/artifact/patchprocess/testrun_hadoop-yarn-api.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/7703/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/7703/console | This message was automatically generated. > Cleanup ResourceManagerAdministrationProtocol interface audience > ---------------------------------------------------------------- > > Key: YARN-3523 > URL: https://issues.apache.org/jira/browse/YARN-3523 > Project: Hadoop YARN > Issue Type: Bug > Components: client, resourcemanager > Reporter: Wangda Tan > Assignee: Naganarasimha G R > Labels: newbie > Attachments: YARN-3523.20150422-1.patch, YARN-3523.20150504-1.patch, > YARN-3523.20150505-1.patch > > > I noticed ResourceManagerAdministrationProtocol has @Private audience for the > class and @Public audience for methods. It doesn't make sense to me. We > should make class audience and methods audience consistent. -- This message was sent by Atlassian JIRA (v6.3.4#6332)