[
https://issues.apache.org/jira/browse/YARN-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506160#comment-14506160
]
Vinod Kumar Vavilapalli commented on YARN-3366:
-----------------------------------------------
Comments on the patch - The formatting in all the new files is a bit off.
- Add a bit of javadoc to TrafficControlBandwidthHandlerImpl ?
- You may want to mark YarnConfiguration.DEFAULT_NM_NETWORK_* constants also
as Private, given the config knobs are.
- outbound-bandwidth-mbit -> node-outbound-bandwidth-mbit and
outbound-bandwidth-yarn-mbit -> yarn-outbound-bandwidth-mbit?
- {{conf.get("hadoop.tmp.dir")}}: We should write to the nmPrivate directories
instead of /tmp.
- TrafficController
-- Can the patterns used in
checkIfAlreadyBootstrapped()/reacquireContainerClasses() etc be compiled once
and reused?
-- What is MIN_CONTAINER_CLASS_ID? Add some javadoc? May be for other
constants?
- Fork off BatchBuilder into its own class?
- TrafficControlBandwidthHandlerImpl: getBytesSentPerContainer() for future
use?
> Outbound network bandwidth : classify/shape traffic originating from YARN
> containers
> ------------------------------------------------------------------------------------
>
> Key: YARN-3366
> URL: https://issues.apache.org/jira/browse/YARN-3366
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Sidharta Seethana
> Assignee: Sidharta Seethana
> Attachments: YARN-3366.001.patch, YARN-3366.002.patch,
> YARN-3366.003.patch, YARN-3366.004.patch, YARN-3366.005.patch,
> YARN-3366.006.patch
>
>
> In order to be able to isolate based on/enforce outbound traffic bandwidth
> limits, we need a mechanism to classify/shape network traffic in the
> nodemanager. For more information on the design, please see the attached
> design document in the parent JIRA.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
