[
https://issues.apache.org/jira/browse/YARN-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506188#comment-14506188
]
Sidharta Seethana commented on YARN-3366:
-----------------------------------------
Thanks for your feedback, [~vinodkv] . Responses inline :
{quote}
Add a bit of javadoc to TrafficControlBandwidthHandlerImpl ?
{quote}
Sure, I'll do that.
{quote}
You may want to mark YarnConfiguration.DEFAULT_NM_NETWORK_* constants also as
Private, given the config knobs are.
{quote}
Will do.
{quote}
outbound-bandwidth-mbit -> node-outbound-bandwidth-mbit and
outbound-bandwidth-yarn-mbit -> yarn-outbound-bandwidth-mbit?
{quote}
"outbound-bandwidth" is used a prefix for these config params. I would rather
leave them as is for now - especially since they are likely to be changed in
the future.
{quote}
conf.get("hadoop.tmp.dir"): We should write to the nmPrivate directories
instead of /tmp.
{quote}
I'll figure out a way to do this.
{quote}
TrafficController
Can the patterns used in
checkIfAlreadyBootstrapped()/reacquireContainerClasses() etc be compiled once
and reused?
{quote}
There isn't much value to doing this - these are executed once during NM
startup and the regex patterns are not re-used.
{quote}
What is MIN_CONTAINER_CLASS_ID? Add some javadoc? May be for other constants?
{quote}
Some classids are already used to setup a hierarchy of classes.
MIN_CONTAINER_CLASS_ID is used to ensure that there are no collisions.
{quote}
Fork off BatchBuilder into its own class?
{quote}
I am afraid this isn't possible/easy - The builder class is designed to make tc
command generation easier and it very closely tied to the TrafficController
class.
{quote}
TrafficControlBandwidthHandlerImpl: getBytesSentPerContainer() for future use?
{quote}
Yes, this is meant to provide metrics at a container level - when it is hooked
in. I'll add a note.
> Outbound network bandwidth : classify/shape traffic originating from YARN
> containers
> ------------------------------------------------------------------------------------
>
> Key: YARN-3366
> URL: https://issues.apache.org/jira/browse/YARN-3366
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Sidharta Seethana
> Assignee: Sidharta Seethana
> Attachments: YARN-3366.001.patch, YARN-3366.002.patch,
> YARN-3366.003.patch, YARN-3366.004.patch, YARN-3366.005.patch,
> YARN-3366.006.patch
>
>
> In order to be able to isolate based on/enforce outbound traffic bandwidth
> limits, we need a mechanism to classify/shape network traffic in the
> nodemanager. For more information on the design, please see the attached
> design document in the parent JIRA.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
